Skip to content
Snippets Groups Projects

Ed 1002

Merged Erdem A Memisyazici requested to merge ED-1002 into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Fisher
    Daniel Fisher @dfisher started a thread on commit 63eddc5e
    Last updated by Erdem A Memisyazici
    8
    9 /**
    10 *
    11 * @author ememisya
    12 */
    13 public class VirginiaTechGroup
    14 {
    15
    16 //MAY
    17
    18
    19 //MUST
    20
    21
    22
    23 }
    • Always diff before you push a commit. Classes should have javadocs complete when they come in.

    • Again, this is just the initial branch creation. There is still a ton of work to be done for this to be completed, I just wanted to be able to pull it down remotely if need be to continue from there on.

    • Owner

      Not crazy about an interfaces package. What's your reasoning for putting them in a separate package?

    • I was going to call it contracts package, I personally think it looks cleaner in the end. I only leave the exceptions, enums and common classes at the base package usually. I could change it if you'd like.

    • Please register or sign in to reply
  • Daniel Fisher
    Daniel Fisher @dfisher started a thread on commit 6e899a27
    Last updated by Erdem A Memisyazici
    126 final Map<String, String[]> authorizationMap,
    127 final AuthorizationMethod method)
    128 throws LdapException, EdAuthAuthorizationException
    150 final String user,
    151 final Credential credential,
    152 final Map<String, String[]> authorizationMap,
    153 final AuthorizationMethod method)
    154 throws LdapException, EdAuthAuthorizationException
    129 155 {
    130 156
    131 157 boolean authorized = false;
    132 158
    133 159 if (authorizationMap.keySet().isEmpty()) {
    134 160 throw new EdAuthAuthorizationException(
    135 EdAuthAuthorizationException.EDAUTH_EXCEPTION_MSG_KEYSET_EMPTY);
    161 EdAuthAuthorizationException.EDAUTH_EXCEPTION_MSG_KEYSET_EMPTY);
    • Lots of changes here that appear to be reformatting. Try to avoid these, they create a lot of noise and our source cleanup will just change it back at some future commit.

    • Yup, I will run it through checkstyle ultimately. As a habit I always do ALT+SHIFT+F every other line which autoformats it, but checkstyle doesn't like long lines. Again, this is just a point in which I had no errors. As it stands there are still no javadocs, mapping function is not implemented, no test classes, nor required exception handling for the time being, nor the certificate options, nor the new realm support. Rest assured when I make the merge request these will be taken care of. It's being chiseled, not polished yet :)

Please register or sign in to reply