Skip to content
Snippets Groups Projects
Commit 1f873ace authored by Jonas Van Goolen's avatar Jonas Van Goolen
Browse files

#150 TSLint error fixing

parent 9b812100
Branches
Tags
No related merge requests found
Showing
with 49 additions and 67 deletions
...@@ -40,7 +40,6 @@ describe('ObjectCollectionComponent', () => { ...@@ -40,7 +40,6 @@ describe('ObjectCollectionComponent', () => {
it('should only show the grid component when the viewmode is set to grid', () => { it('should only show the grid component when the viewmode is set to grid', () => {
objectCollectionComponent.currentMode = ViewMode.Grid; objectCollectionComponent.currentMode = ViewMode.Grid;
expect(fixture.debugElement.query(By.css('ds-object-grid'))).toBeDefined(); expect(fixture.debugElement.query(By.css('ds-object-grid'))).toBeDefined();
expect(fixture.debugElement.query(By.css('ds-object-list'))).toBeNull(); expect(fixture.debugElement.query(By.css('ds-object-list'))).toBeNull();
}); });
......
...@@ -65,14 +65,13 @@ export class ObjectCollectionComponent implements OnChanges, OnInit { ...@@ -65,14 +65,13 @@ export class ObjectCollectionComponent implements OnChanges, OnInit {
} }
} }
ngOnInit(): void { ngOnInit(): void {
// this.pageInfo = this.objects.pageInfo; // this.pageInfo = this.objects.pageInfo;
this.sub = this.route this.sub = this.route
.queryParams .queryParams
.subscribe((params) => { .subscribe((params) => {
if(isNotEmpty(params.view)){ if (isNotEmpty(params.view)) {
this.currentMode = params.view; this.currentMode = params.view;
} }
}); });
...@@ -91,7 +90,7 @@ export class ObjectCollectionComponent implements OnChanges, OnInit { ...@@ -91,7 +90,7 @@ export class ObjectCollectionComponent implements OnChanges, OnInit {
getViewMode(): ViewMode { getViewMode(): ViewMode {
this.route.queryParams.map((params) => { this.route.queryParams.map((params) => {
if (isNotEmpty(params.view) && hasValue(params.view)) { if (isNotEmpty(params.view) && hasValue(params.view)) {
this.currentMode= params.view; this.currentMode = params.view;
} }
}); });
return this.currentMode; return this.currentMode;
......
...@@ -3,8 +3,8 @@ import { renderElementsFor } from './dso-element-decorator'; ...@@ -3,8 +3,8 @@ import { renderElementsFor } from './dso-element-decorator';
import { Item } from '../../../core/shared/item.model'; import { Item } from '../../../core/shared/item.model';
describe('ElementDecorator', () => { describe('ElementDecorator', () => {
let gridDecorator = renderElementsFor(Item, ViewMode.Grid); const gridDecorator = renderElementsFor(Item, ViewMode.Grid);
let listDecorator = renderElementsFor(Item, ViewMode.List); const listDecorator = renderElementsFor(Item, ViewMode.List);
it('should have a decorator for both list and grid', () => { it('should have a decorator for both list and grid', () => {
expect(listDecorator.length).not.toBeNull(); expect(listDecorator.length).not.toBeNull();
expect(gridDecorator.length).not.toBeNull(); expect(gridDecorator.length).not.toBeNull();
......
...@@ -6,8 +6,6 @@ import { RouterStub } from '../../testing/router-stub'; ...@@ -6,8 +6,6 @@ import { RouterStub } from '../../testing/router-stub';
import { NO_ERRORS_SCHEMA } from '@angular/core'; import { NO_ERRORS_SCHEMA } from '@angular/core';
import { By } from '@angular/platform-browser'; import { By } from '@angular/platform-browser';
import { Collection } from '../../../core/shared/collection.model'; import { Collection } from '../../../core/shared/collection.model';
let collectionGridElementComponent: CollectionGridElementComponent;
let fixture: ComponentFixture<CollectionGridElementComponent>; let fixture: ComponentFixture<CollectionGridElementComponent>;
const queryParam = 'test query'; const queryParam = 'test query';
const scopeParam = '7669c72a-3f2a-451f-a3b9-9210e7a4c02f'; const scopeParam = '7669c72a-3f2a-451f-a3b9-9210e7a4c02f';
...@@ -17,7 +15,7 @@ const activatedRouteStub = { ...@@ -17,7 +15,7 @@ const activatedRouteStub = {
scope: scopeParam scope: scopeParam
}) })
}; };
let mockCollection: Collection = Object.assign(new Collection(), { const mockCollection: Collection = Object.assign(new Collection(), {
metadata: [ metadata: [
{ {
key: 'dc.description.abstract', key: 'dc.description.abstract',
...@@ -25,7 +23,7 @@ let mockCollection: Collection = Object.assign(new Collection(), { ...@@ -25,7 +23,7 @@ let mockCollection: Collection = Object.assign(new Collection(), {
value: 'Short description' value: 'Short description'
}] }]
}); });
let createdGridElementComponent:CollectionGridElementComponent= new CollectionGridElementComponent(mockCollection); const createdGridElementComponent:CollectionGridElementComponent= new CollectionGridElementComponent(mockCollection);
describe('CollectionGridElementComponent', () => { describe('CollectionGridElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
...@@ -45,16 +43,16 @@ describe('CollectionGridElementComponent', () => { ...@@ -45,16 +43,16 @@ describe('CollectionGridElementComponent', () => {
fixture = TestBed.createComponent(CollectionGridElementComponent); fixture = TestBed.createComponent(CollectionGridElementComponent);
})); }));
it('should show the collection cards in the grid element',()=>{ it('should show the collection cards in the grid element',() => {
expect(fixture.debugElement.query(By.css('ds-collection-grid-element'))).toBeDefined(); expect(fixture.debugElement.query(By.css('ds-collection-grid-element'))).toBeDefined();
}); });
it('should only show the description if "short description" metadata is present',()=>{ it('should only show the description if "short description" metadata is present',() => {
let descriptionText = expect(fixture.debugElement.query(By.css('p.card-text'))); const descriptionText = expect(fixture.debugElement.query(By.css('p.card-text')));
if(mockCollection.shortDescription.length>0){ if (mockCollection.shortDescription.length > 0) {
expect(descriptionText).toBeDefined(); expect(descriptionText).toBeDefined();
}else{ }else {
expect(descriptionText).not.toBeDefined(); expect(descriptionText).not.toBeDefined();
} }
}); });
......
...@@ -5,7 +5,6 @@ import { renderElementsFor} from '../../object-collection/shared/dso-element-dec ...@@ -5,7 +5,6 @@ import { renderElementsFor} from '../../object-collection/shared/dso-element-dec
import { ViewMode } from '../../../+search-page/search-options.model'; import { ViewMode } from '../../../+search-page/search-options.model';
import { AbstractListableElementComponent } from '../../object-collection/shared/object-collection-element/abstract-listable-element.component'; import { AbstractListableElementComponent } from '../../object-collection/shared/object-collection-element/abstract-listable-element.component';
@Component({ @Component({
selector: 'ds-collection-grid-element', selector: 'ds-collection-grid-element',
styleUrls: ['./collection-grid-element.component.scss'], styleUrls: ['./collection-grid-element.component.scss'],
......
...@@ -19,7 +19,7 @@ const activatedRouteStub = { ...@@ -19,7 +19,7 @@ const activatedRouteStub = {
}) })
}; };
let mockCommunity: Community = Object.assign(new Community(), { const mockCommunity: Community = Object.assign(new Community(), {
metadata: [ metadata: [
{ {
key: 'dc.description.abstract', key: 'dc.description.abstract',
...@@ -28,7 +28,7 @@ let mockCommunity: Community = Object.assign(new Community(), { ...@@ -28,7 +28,7 @@ let mockCommunity: Community = Object.assign(new Community(), {
}] }]
}); });
let createdGridElementComponent:CommunityGridElementComponent= new CommunityGridElementComponent(mockCommunity); const createdGridElementComponent:CommunityGridElementComponent= new CommunityGridElementComponent(mockCommunity);
describe('CommunityGridElementComponent', () => { describe('CommunityGridElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
...@@ -50,16 +50,16 @@ describe('CommunityGridElementComponent', () => { ...@@ -50,16 +50,16 @@ describe('CommunityGridElementComponent', () => {
})); }));
it('should show the community cards in the grid element',()=>{ it('should show the community cards in the grid element',() => {
expect(fixture.debugElement.query(By.css('ds-community-grid-element'))).toBeDefined(); expect(fixture.debugElement.query(By.css('ds-community-grid-element'))).toBeDefined();
}) })
it('should only show the description if "short description" metadata is present',()=>{ it('should only show the description if "short description" metadata is present',() => {
let descriptionText = expect(fixture.debugElement.query(By.css('p.card-text'))); const descriptionText = expect(fixture.debugElement.query(By.css('p.card-text')));
if(mockCommunity.shortDescription.length>0){ if (mockCommunity.shortDescription.length > 0) {
expect(descriptionText).toBeDefined(); expect(descriptionText).toBeDefined();
}else{ }else {
expect(descriptionText).not.toBeDefined(); expect(descriptionText).not.toBeDefined();
} }
}); });
......
...@@ -19,7 +19,7 @@ const activatedRouteStub = { ...@@ -19,7 +19,7 @@ const activatedRouteStub = {
}) })
}; };
/* tslint:disable:no-shadowed-variable */ /* tslint:disable:no-shadowed-variable */
let mockItem: Item = Object.assign(new Item(), { const mockItem: Item = Object.assign(new Item(), {
metadata: [ metadata: [
{ {
key: 'dc.contributor.author', key: 'dc.contributor.author',
...@@ -28,7 +28,7 @@ let mockItem: Item = Object.assign(new Item(), { ...@@ -28,7 +28,7 @@ let mockItem: Item = Object.assign(new Item(), {
}] }]
}); });
let createdGridElementComponent:ItemGridElementComponent= new ItemGridElementComponent(mockItem); const createdGridElementComponent:ItemGridElementComponent= new ItemGridElementComponent(mockItem);
describe('ItemGridElementComponent', () => { describe('ItemGridElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
...@@ -50,19 +50,18 @@ describe('ItemGridElementComponent', () => { ...@@ -50,19 +50,18 @@ describe('ItemGridElementComponent', () => {
})); }));
it('should show the item cards in the grid element',()=>{ it('should show the item cards in the grid element',() => {
expect(fixture.debugElement.query(By.css('ds-item-grid-element'))).toBeDefined() expect(fixture.debugElement.query(By.css('ds-item-grid-element'))).toBeDefined()
}); });
it('should only show the author span if the author metadata is present',()=>{ it('should only show the author span if the author metadata is present',() => {
let itemAuthorField = expect(fixture.debugElement.query(By.css('p.item-authors'))); const itemAuthorField = expect(fixture.debugElement.query(By.css('p.item-authors')));
if(mockItem.filterMetadata(['dc.contributor.author', 'dc.creator', 'dc.contributor.*']).length>0){ if (mockItem.filterMetadata(['dc.contributor.author', 'dc.creator', 'dc.contributor.*']).length > 0) {
expect(itemAuthorField).toBeDefined(); expect(itemAuthorField).toBeDefined();
}else{ }else {
expect(itemAuthorField).toBeDefined(); expect(itemAuthorField).toBeDefined();
} }
}); });
}) })
...@@ -9,7 +9,6 @@ import { TruncatePipe } from '../../../utils/truncate.pipe'; ...@@ -9,7 +9,6 @@ import { TruncatePipe } from '../../../utils/truncate.pipe';
import { Community } from '../../../../core/shared/community.model'; import { Community } from '../../../../core/shared/community.model';
import { Collection } from '../../../../core/shared/collection.model'; import { Collection } from '../../../../core/shared/collection.model';
let fixture: ComponentFixture<CollectionSearchResultGridElementComponent>; let fixture: ComponentFixture<CollectionSearchResultGridElementComponent>;
const queryParam = 'test query'; const queryParam = 'test query';
const scopeParam = '7669c72a-3f2a-451f-a3b9-9210e7a4c02f'; const scopeParam = '7669c72a-3f2a-451f-a3b9-9210e7a4c02f';
...@@ -19,7 +18,7 @@ const activatedRouteStub = { ...@@ -19,7 +18,7 @@ const activatedRouteStub = {
scope: scopeParam scope: scopeParam
}) })
}; };
let mockCollection: Collection = Object.assign(new Collection(), { const mockCollection: Collection = Object.assign(new Collection(), {
metadata: [ metadata: [
{ {
key: 'dc.description.abstract', key: 'dc.description.abstract',
...@@ -29,8 +28,7 @@ let mockCollection: Collection = Object.assign(new Collection(), { ...@@ -29,8 +28,7 @@ let mockCollection: Collection = Object.assign(new Collection(), {
}); });
let createdGridElementComponent: CollectionSearchResultGridElementComponent = new CollectionSearchResultGridElementComponent(mockCollection); const createdGridElementComponent: CollectionSearchResultGridElementComponent = new CollectionSearchResultGridElementComponent(mockCollection);
describe('CollectionSearchResultGridElementComponent', () => { describe('CollectionSearchResultGridElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
...@@ -54,13 +52,12 @@ describe('CollectionSearchResultGridElementComponent', () => { ...@@ -54,13 +52,12 @@ describe('CollectionSearchResultGridElementComponent', () => {
expect(fixture.debugElement.query(By.css('ds-collection-search-result-grid-element'))).toBeDefined(); expect(fixture.debugElement.query(By.css('ds-collection-search-result-grid-element'))).toBeDefined();
}); });
it('should only show the description if "short description" metadata is present',() => {
const descriptionText = expect(fixture.debugElement.query(By.css('p.card-text')));
it('should only show the description if "short description" metadata is present',()=>{ if (mockCollection.shortDescription.length > 0) {
let descriptionText = expect(fixture.debugElement.query(By.css('p.card-text')));
if(mockCollection.shortDescription.length>0){
expect(descriptionText).toBeDefined(); expect(descriptionText).toBeDefined();
}else{ }else {
expect(descriptionText).not.toBeDefined(); expect(descriptionText).not.toBeDefined();
} }
}); });
......
...@@ -8,8 +8,6 @@ import { By } from '@angular/platform-browser'; ...@@ -8,8 +8,6 @@ import { By } from '@angular/platform-browser';
import { TruncatePipe } from '../../../utils/truncate.pipe'; import { TruncatePipe } from '../../../utils/truncate.pipe';
import { Community } from '../../../../core/shared/community.model'; import { Community } from '../../../../core/shared/community.model';
let communitySearchResultGridElementComponent: CommunitySearchResultGridElementComponent;
let fixture: ComponentFixture<CommunitySearchResultGridElementComponent>; let fixture: ComponentFixture<CommunitySearchResultGridElementComponent>;
const queryParam = 'test query'; const queryParam = 'test query';
const scopeParam = '7669c72a-3f2a-451f-a3b9-9210e7a4c02f'; const scopeParam = '7669c72a-3f2a-451f-a3b9-9210e7a4c02f';
...@@ -19,7 +17,7 @@ const activatedRouteStub = { ...@@ -19,7 +17,7 @@ const activatedRouteStub = {
scope: scopeParam scope: scopeParam
}) })
}; };
let mockCommunity: Community = Object.assign(new Community(), { const mockCommunity: Community = Object.assign(new Community(), {
metadata: [ metadata: [
{ {
key: 'dc.description.abstract', key: 'dc.description.abstract',
...@@ -29,8 +27,7 @@ let mockCommunity: Community = Object.assign(new Community(), { ...@@ -29,8 +27,7 @@ let mockCommunity: Community = Object.assign(new Community(), {
}); });
let createdGridElementComponent: CommunitySearchResultGridElementComponent = new CommunitySearchResultGridElementComponent(mockCommunity); const createdGridElementComponent: CommunitySearchResultGridElementComponent = new CommunitySearchResultGridElementComponent(mockCommunity);
describe('CommunitySearchResultGridElementComponent', () => { describe('CommunitySearchResultGridElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
...@@ -54,13 +51,12 @@ describe('CommunitySearchResultGridElementComponent', () => { ...@@ -54,13 +51,12 @@ describe('CommunitySearchResultGridElementComponent', () => {
expect(fixture.debugElement.query(By.css('ds-community-search-result-grid-element'))).toBeDefined(); expect(fixture.debugElement.query(By.css('ds-community-search-result-grid-element'))).toBeDefined();
}); });
it('should only show the description if "short description" metadata is present',() => {
const descriptionText = expect(fixture.debugElement.query(By.css('p.card-text')));
it('should only show the description if "short description" metadata is present',()=>{ if (mockCommunity.shortDescription.length > 0) {
let descriptionText = expect(fixture.debugElement.query(By.css('p.card-text')));
if(mockCommunity.shortDescription.length>0){
expect(descriptionText).toBeDefined(); expect(descriptionText).toBeDefined();
}else{ }else {
expect(descriptionText).not.toBeDefined(); expect(descriptionText).not.toBeDefined();
} }
}); });
......
...@@ -8,7 +8,6 @@ import { By } from '@angular/platform-browser'; ...@@ -8,7 +8,6 @@ import { By } from '@angular/platform-browser';
import { TruncatePipe } from '../../../utils/truncate.pipe'; import { TruncatePipe } from '../../../utils/truncate.pipe';
import { Item } from '../../../../core/shared/item.model'; import { Item } from '../../../../core/shared/item.model';
let itemSearchResultGridElementComponent: ItemSearchResultGridElementComponent; let itemSearchResultGridElementComponent: ItemSearchResultGridElementComponent;
let fixture: ComponentFixture<ItemSearchResultGridElementComponent>; let fixture: ComponentFixture<ItemSearchResultGridElementComponent>;
const queryParam = 'test query'; const queryParam = 'test query';
...@@ -19,7 +18,7 @@ const activatedRouteStub = { ...@@ -19,7 +18,7 @@ const activatedRouteStub = {
scope: scopeParam scope: scopeParam
}) })
}; };
let mockItem: Item = Object.assign(new Item(), { const mockItem: Item = Object.assign(new Item(), {
metadata: [ metadata: [
{ {
key: 'dc.contributor.author', key: 'dc.contributor.author',
...@@ -32,7 +31,7 @@ let mockItem: Item = Object.assign(new Item(), { ...@@ -32,7 +31,7 @@ let mockItem: Item = Object.assign(new Item(), {
value: '1650-06-26' value: '1650-06-26'
}] }]
}); });
let createdGridElementComponent:ItemSearchResultGridElementComponent= new ItemSearchResultGridElementComponent(mockItem); const createdGridElementComponent:ItemSearchResultGridElementComponent= new ItemSearchResultGridElementComponent(mockItem);
describe('ItemSearchResultGridElementComponent', () => { describe('ItemSearchResultGridElementComponent', () => {
beforeEach(async(() => { beforeEach(async(() => {
...@@ -54,31 +53,28 @@ describe('ItemSearchResultGridElementComponent', () => { ...@@ -54,31 +53,28 @@ describe('ItemSearchResultGridElementComponent', () => {
})); }));
it('should show the item result cards in the grid element',()=>{ it('should show the item result cards in the grid element',() => {
expect(fixture.debugElement.query(By.css('ds-item-search-result-grid-element'))).toBeDefined(); expect(fixture.debugElement.query(By.css('ds-item-search-result-grid-element'))).toBeDefined();
}); });
it('should only show the author span if the author metadata is present',()=>{ it('should only show the author span if the author metadata is present',() => {
let itemAuthorField = expect(fixture.debugElement.query(By.css('p.item-authors'))); const itemAuthorField = expect(fixture.debugElement.query(By.css('p.item-authors')));
if(mockItem.filterMetadata(['dc.contributor.author', 'dc.creator', 'dc.contributor.*']).length>0){ if (mockItem.filterMetadata(['dc.contributor.author', 'dc.creator', 'dc.contributor.*']).length > 0) {
expect(itemAuthorField).toBeDefined(); expect(itemAuthorField).toBeDefined();
}else{ }else {
expect(itemAuthorField).not.toBeDefined(); expect(itemAuthorField).not.toBeDefined();
} }
}); });
it('should only show the date span if the issuedate is present',()=>{ it('should only show the date span if the issuedate is present',() => {
let dateField = expect(fixture.debugElement.query(By.css('span.item-list-date'))); const dateField = expect(fixture.debugElement.query(By.css('span.item-list-date')));
if(mockItem.findMetadata('dc.date.issued').length>0){ if (mockItem.findMetadata('dc.date.issued').length > 0) {
expect(dateField).toBeDefined(); expect(dateField).toBeDefined();
}else{ }else {
expect(dateField).not.toBeDefined(); expect(dateField).not.toBeDefined();
} }
}); });
}); });
...@@ -37,7 +37,7 @@ describe('WrapperGridElementComponent', () => { ...@@ -37,7 +37,7 @@ describe('WrapperGridElementComponent', () => {
})); }));
it('should show the wrapper element containing the cards',()=>{ it('should show the wrapper element containing the cards',() => {
expect(fixture.debugElement.query(By.css('ds-collection-grid-element'))).toBeDefined(); expect(fixture.debugElement.query(By.css('ds-collection-grid-element'))).toBeDefined();
}) })
}) })
...@@ -18,7 +18,6 @@ import { fadeIn } from '../animations/fade'; ...@@ -18,7 +18,6 @@ import { fadeIn } from '../animations/fade';
import { ListableObject } from '../object-collection/shared/listable-object.model'; import { ListableObject } from '../object-collection/shared/listable-object.model';
import { hasValue } from '../empty.util'; import { hasValue } from '../empty.util';
@Component({ @Component({
changeDetection: ChangeDetectionStrategy.Default, changeDetection: ChangeDetectionStrategy.Default,
encapsulation: ViewEncapsulation.Emulated, encapsulation: ViewEncapsulation.Emulated,
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment