Skip to content
Snippets Groups Projects
Commit fa86601f authored by lotte's avatar lotte
Browse files

applied feedback

parent 1b6c0a9e
No related branches found
No related tags found
No related merge requests found
......@@ -19,7 +19,7 @@ import { SortDirection, SortOptions } from '../../../core/cache/models/sort-opti
import { PaginationComponentOptions } from '../../../shared/pagination/pagination-component-options.model';
import { SearchFixedFilterService } from './search-fixed-filter.service';
import { Params } from '@angular/router';
// const spy = create();
const filterStateSelector = (state: SearchFiltersState) => state.searchFilter;
export const FILTER_CONFIG: InjectionToken<SearchFilterConfig> = new InjectionToken<SearchFilterConfig>('filterConfig');
......
import {SearchFixedFilterService} from './search-fixed-filter.service';
import {RequestService} from '../../../core/data/request.service';
import {HALEndpointService} from '../../../core/shared/hal-endpoint.service';
import {of as observableOf} from 'rxjs';
import {RequestEntry} from '../../../core/data/request.reducer';
import {FilteredDiscoveryQueryResponse} from '../../../core/cache/response.models';
import { SearchFixedFilterService } from './search-fixed-filter.service';
import { RequestService } from '../../../core/data/request.service';
import { HALEndpointService } from '../../../core/shared/hal-endpoint.service';
import { of as observableOf } from 'rxjs';
import { RequestEntry } from '../../../core/data/request.reducer';
import { FilteredDiscoveryQueryResponse } from '../../../core/cache/response.models';
describe('SearchFixedFilterService', () => {
let service: SearchFixedFilterService;
......@@ -12,7 +12,8 @@ describe('SearchFixedFilterService', () => {
const requestServiceStub = Object.assign({
/* tslint:disable:no-empty */
configure: () => {},
configure: () => {
},
/* tslint:enable:no-empty */
generateRequestId: () => 'fake-id',
getByHref: () => observableOf(Object.assign(new RequestEntry(), {
......
......@@ -5,12 +5,12 @@ import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { Observable, of as observableOf } from 'rxjs';
import { Params } from '@angular/router';
import {SearchLabelComponent} from './search-label.component';
import {ObjectKeysPipe} from '../../../shared/utils/object-keys-pipe';
import {SearchService} from '../../search-service/search.service';
import {SEARCH_CONFIG_SERVICE} from '../../../+my-dspace-page/my-dspace-page.component';
import {SearchServiceStub} from '../../../shared/testing/search-service-stub';
import {SearchConfigurationServiceStub} from '../../../shared/testing/search-configuration-service-stub';
import { SearchLabelComponent } from './search-label.component';
import { ObjectKeysPipe } from '../../../shared/utils/object-keys-pipe';
import { SearchService } from '../../search-service/search.service';
import { SEARCH_CONFIG_SERVICE } from '../../../+my-dspace-page/my-dspace-page.component';
import { SearchServiceStub } from '../../../shared/testing/search-service-stub';
import { SearchConfigurationServiceStub } from '../../../shared/testing/search-configuration-service-stub';
describe('SearchLabelComponent', () => {
let comp: SearchLabelComponent;
......
import {SearchLabelsComponent} from './search-labels.component';
import {async, ComponentFixture, TestBed} from '@angular/core/testing';
import {NoopAnimationsModule} from '@angular/platform-browser/animations';
import {TranslateModule} from '@ngx-translate/core';
import {SearchService} from '../search-service/search.service';
import {ChangeDetectionStrategy, NO_ERRORS_SCHEMA} from '@angular/core';
import {FormsModule} from '@angular/forms';
import {SearchServiceStub} from '../../shared/testing/search-service-stub';
import {of as observableOf} from 'rxjs';
import {ObjectKeysPipe} from '../../shared/utils/object-keys-pipe';
import {SEARCH_CONFIG_SERVICE} from '../../+my-dspace-page/my-dspace-page.component';
import { SearchLabelsComponent } from './search-labels.component';
import { async, ComponentFixture, TestBed } from '@angular/core/testing';
import { NoopAnimationsModule } from '@angular/platform-browser/animations';
import { TranslateModule } from '@ngx-translate/core';
import { SearchService } from '../search-service/search.service';
import { ChangeDetectionStrategy, NO_ERRORS_SCHEMA } from '@angular/core';
import { FormsModule } from '@angular/forms';
import { SearchServiceStub } from '../../shared/testing/search-service-stub';
import { of as observableOf } from 'rxjs';
import { ObjectKeysPipe } from '../../shared/utils/object-keys-pipe';
import { SEARCH_CONFIG_SERVICE } from '../../+my-dspace-page/my-dspace-page.component';
describe('SearchLabelsComponent', () => {
let comp: SearchLabelsComponent;
......@@ -34,7 +34,7 @@ describe('SearchLabelsComponent', () => {
declarations: [SearchLabelsComponent, ObjectKeysPipe],
providers: [
{ provide: SearchService, useValue: new SearchServiceStub(searchLink) },
{ provide: SEARCH_CONFIG_SERVICE, useValue: {getCurrentFrontendFilters : () => observableOf(mockFilters)} }
{ provide: SEARCH_CONFIG_SERVICE, useValue: { getCurrentFrontendFilters: () => observableOf(mockFilters) } }
],
schemas: [NO_ERRORS_SCHEMA]
}).overrideComponent(SearchLabelsComponent, {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment