Skip to content
Snippets Groups Projects
  1. Dec 17, 2019
  2. Dec 12, 2019
    • Robert Raposa's avatar
      remove /login_post endpoint · a9825889
      Robert Raposa authored
      - retires toggle DISABLE_DEPRECATED_LOGIN_POST
      - permanently removes /login_post
      
      Now that studio signin has been retired, we are able to remove the
      unused /login_post endpoint.
      
      ARCH-1253
      a9825889
  3. Dec 06, 2019
  4. Dec 04, 2019
    • Robert Raposa's avatar
      remove studio signin and signup pages · 2202545a
      Robert Raposa authored
      This completes the work started in https://github.com/edx/edx-platform/pull/19453
      to use the LMS login and registration for Studio, rather than Studio
      providing its own implementation.
      
      LMS login/registration are being used for the following reasons:
      1. LMS logistration properly handles all SSO integrations.
      2. A single logistration is simpler to maintain and understand.
      3. Allows Studio to work more like all other IDAs that use LMS
      logistration.
      
      The original switch to use LMS logistration for Studio also added the
      toggle `DISABLE_STUDIO_SSO_OVER_LMS` to provide the community some
      additional time for switching. This commit removes this toggle, which
      at this point means all deployments will use the LMS logistration.
      
      This change requires sharing cookies across LMS and Studio. Should that
      prove to be a problem for certain Open edX instances, there are
      discussions of possible alternative solutions.
      See https://github.com/edx/edx-platform/pull/19845#issuecomment-559154256
      
      Detailed changes:
      * Fix some Studio links that still went to old Studio signin and signup.
      * Remove DISABLE_STUDIO_SSO_OVER_LMS feature toggle.
      * Remove old studio signin and signup pages and templates.
      * Fix url name "login", which had different meanings for Studio and LMS.
      * Use the following settings: LOGIN_URL, FRONTEND_LOGIN_URL,
      FRONTEND_LOGOUT_URL, and FRONTEND_REGISTER_URL.
      * Redirect /signin and /signup to the LMS logistration.
      * Add custom metric `uses_pattern_library`.
      * Add custom metric `student_activate_account`.
      * Add Django Settings to allow /signin, /signup, and /login_post to be
      disabled once ready.
      
      This work also relates to ARCH-218 and DEPR-6.
      
      ARCH-1253
      2202545a
  5. Dec 03, 2019
  6. Nov 26, 2019
  7. Nov 25, 2019
  8. Nov 21, 2019
  9. Nov 14, 2019
  10. Nov 12, 2019
  11. Nov 07, 2019
    • Dave St.Germain's avatar
      TNL-6929: · 3e73ba38
      Dave St.Germain authored
      Improves navigation within Studio for Learning Sequences, speeding up authors who want to see how a learner progresses through content without needing to jump over to the LMS.
      
      This adds a dropdown section navigator to the breadcrumbs on the unit page and copies the sequence navigator from LMS to the studio unit page.
      3e73ba38
  12. Nov 06, 2019
  13. Nov 01, 2019
    • Awais Qureshi's avatar
      BOM-998 · 076a2b5a
      Awais Qureshi authored
      Fixing decoding issue.
      Fixing flaky unit test.
      076a2b5a
  14. Oct 31, 2019
  15. Oct 30, 2019
  16. Oct 29, 2019
  17. Oct 28, 2019
    • Dave St.Germain's avatar
      TNL-6968 · 05e0de29
      Dave St.Germain authored
      The access settings modal should not have an editable title. Also, the title of the modal was not being interpolated correctly.
      05e0de29
  18. Oct 24, 2019
    • Manjinder Singh's avatar
      BOM-933: Fix type mismatches in various migrations 5 (#22147) · 80c7f5af
      Manjinder Singh authored
      * fix type mismatch in third_party_auth migrations
      
      * fix type mismatch in verify_student  migrations
      
      * fix type mismatch in video_config  migrations
      
      * fix type mismatch in verified_track_content  migrations
      
      * fix type mismatch in commercemigrations
      
      * fix type mismatch in xblock_config migrations
      
      * fix type mismatch in course_creators migrations
      
      * fix type mismatch in contentstore migrations
  19. Oct 21, 2019
  20. Oct 18, 2019
    • Ned Batchelder's avatar
      Revert pull request #22042 · ea30aba6
      Ned Batchelder authored
      Revert "Fix code quality test failures"
      
      This reverts commit 8c55e11d.
      
      Revert "Fix celery send_activation_email task failure"
      
      This reverts commit 810eea0e.
      
      Revert "Convert Account Activation Emails to edx-ACE"
      
      This reverts commit 7984c37a.
      ea30aba6
    • Feanil Patel's avatar
      Create custom pickle serializer. · bfc02dc3
      Feanil Patel authored
      We need to do this because when I tride to go to the JSON serializer a
      bunch of tests started failing because various parts of our code are
      putting things into the session that are not JSON serializable.
      
      We can't keep using the default pickle serializer because it defaluts to
      using the highest available protocol and that will cause issues with the
      python 2 to 3 upgrade since both will be running in production at the
      same time.  We need to use a version of the pickle protocol that both
      can use interchangably.
      
      We also need to make sure we read with latin1 encoding to make datetimes
      work correctly between the two versions of python.
      bfc02dc3
    • Feanil Patel's avatar
      Use the default json session serializer. · 1e97de91
      Feanil Patel authored
      This will force a logout as sessions fail to load but this should be a
      more performant and secure serializer moving forward.  The reason we
      overwrote it in our config is that it previously used to be the default
      and we didn't want things to breake and force logouts when we changed
      it.  We're no more okay with people getting logged out.
      1e97de91
    • syedimranhassan's avatar
    • syedimranhassan's avatar
      6ad9458f
  21. Oct 17, 2019
  22. Oct 14, 2019
  23. Oct 11, 2019
  24. Oct 08, 2019
Loading