Skip to content
Snippets Groups Projects
  1. Apr 02, 2021
  2. Apr 01, 2021
  3. Mar 31, 2021
  4. Mar 30, 2021
  5. Mar 25, 2021
  6. Mar 24, 2021
  7. Mar 23, 2021
  8. Mar 22, 2021
    • Daniel Francis's avatar
      fix: Stop rendering Visibility and Move buttons on libraries (#26885) · 777bb633
      Daniel Francis authored
      We're fixing an error that appears when you click the "edit access"
      button on an XBlock in the library page.
      
      Libraries in the "Add library" page shouldn't have the accessibility
      config icon. Access settings for libraries are changed at the top, on
      Settings > User Access. When clicking the access-button (the cog) on a
      Library, an error appears. This is known to happen on koa.master and
      open-release/juniper.3.
      
      This happens due to the way XBlocks are rendered; as they get rendered
      initially, the previews are unaware of whether they're part of a
      library. We can confirm this by refreshing the page, this makes the
      button disappear.
      
      This fix removes the cogwheel when the XBlock is part of a library.
      This doesn't affect the XBlocks imported to courses because those are
      rendered on a Randomized Content XBlock, which does have its access
      options.
      
      Authored by: Daniel Francis <daniel.francis@opencraft.com>
    • Awais Jibran's avatar
  9. Mar 19, 2021
  10. Mar 18, 2021
  11. Mar 17, 2021
  12. Mar 16, 2021
  13. Mar 15, 2021
    • Awais Qureshi's avatar
      BOM-2453 · 9de74b1b
      Awais Qureshi authored
      tests are failings and complaining related objects doest not exists in
      User table. Create object in test setup to fix it.
      In another fix article id was giving integrity error.
      Fixing task test.
      9de74b1b
    • Awais Qureshi's avatar
      BOM-2453 · 863a70c6
      Awais Qureshi authored
      tests are failings and complaining related objects doest not exists in User table. Create object in test setup to fix it.
      In another fix article id was giving integrity error.
      Fixing task test.
      863a70c6
    • Arslan Ashraf's avatar
    • David Ormsbee's avatar
      feat: Outline error handling and admin improvements. · 3a552c4f
      David Ormsbee authored
      * Introduces the idea of content errors into the learning_sequences
        public API, accessible using get_content_errors().
      * Makes course outline generation much more resilient to unusual
        structures (e.g. Section -> Unit with no Sequence in between),
        with the understanding that anything that doesn't conform to the
        standard structure will simply be skipped.
      * Improves the Django Admin for learning_sequences to display
        content errors and improve sequence data browsing within a course.
      * Switches the main table viewed in the Django admin from
        LearningContext to CourseContext, which is appropriate since only
        course runs generate outlines.
      
      This was done as part of TNL-8057, with the end goal of making
      course outline generation resilient enough to switch over apps
      to using the learning_sequences outline API. The types of course
      structure errors that this PR addresses cause display issues even
      in the current Outline Page experience, but would break the outline
      generation for learning_sequences altogether.
      
      The approach for error messages here is very generic, to keep
      modulestore concepts from seeping into learning_sequences (which is
      not aware of the modulestore/contentstore). We may need to address
      this later, with a more normalized content error data model.
      
      While the Django admin page is backwards compatible with the old
      versions of the models, we should run the backfill_course_outlines
      management command after deploying this change, to get the full
      benefits.
      3a552c4f
    • David Ormsbee's avatar
      feat: Add --force option to backfill_course_outlines. · 36ebb3e1
      David Ormsbee authored
      Adding new functionality is going to require running this command
      on all courses, not just ones that have it missing.
      36ebb3e1
  14. Mar 12, 2021
  15. Mar 11, 2021
    • Usman Khalid's avatar
      XMLModuleStore should use HiddenDescriptor instead of RawDescriptor. · 78cd8be2
      Usman Khalid authored
      In https://github.com/edx/edx-platform/pull/25955 `HiddenDescriptor`
      (which was a subclass of `RawDescriptor` with a custom `student_view()`)
      was converted to an XBlock. It is used as the `default_class` by the
      `CachingDescriptorSystem` classes. However `RawDescriptor` is still
      being used by `XMLModuleStore`. This has been replaced by
      `HiddenDescriptor` as well.
      78cd8be2
    • David Ormsbee's avatar
      fix: Use fallback when titles are unavailable for outlines. · 74ef4664
      David Ormsbee authored
      The Studio UI prevents you from creating a Section or Subsection
      with no title (display_name). But OLX import allows you to bypass
      these checks and create Sections ("chapter" tag) and Subsections
      ("sequential" tag) without display_name information specified in
      the XML. When this happens, Studio and the LMS fall back to using
      the url_name (the last part of the UsageKey) as a title, using the
      display_name_with_default method.
      
      This usually works, because url_names are derived from the import
      file name, and if you're hand-editing a course in XML, your file
      names are probably more intelligible than Mongo object IDs. In any
      case, this commit updates get_outline_from_modulestore to match the
      behavior of Studio and the LMS with respect to this situation.
      
      This is part of the course outlines backfill rollout. TNL-8056
  16. Mar 09, 2021
    • Dillon Dumesnil's avatar
      AA-513: Reset segment state if anon user and there is a segment user id · 16d81f6e
      Dillon Dumesnil authored
      If we are seeing an anonymous user, but the segment user id is still
      set, we believe the segment user id is coming from a different user on
      the same machine. This will make sure we clear out that storage and
      then the indentify call will make a new anonymous id
      16d81f6e
    • David Ormsbee's avatar
      feat: Backfill and Django Admin for Learning Sequence Outline · f5b74fcf
      David Ormsbee authored
      * Adds the backfill_course_outlines management command to contentstore
      * Adds a read-only Django admin interface to learning_sequences for the
        support team and debugging.
      * Adds two new functions to the learning_sequences public API:
        key_supports_outlines and get_course_keys_with_outlines
      
      The learning_sequences app isn't supposed to know about contentstore or
      modulestore, as it's intended to be extracted out of edx-platform in the
      long term. Therefore, the backfill_course_outlines command is in
      contentstore, and not learning_sequences.
      
      This work was tracked in TNL-7983, but it also fixes a bug where we were
      trying to generate course outlines for libraries (TNL-7981).
      
      All Open edX instances upgrading to Lilac should run the
      backfill_course_outlines command as part of their upgrade process.
      f5b74fcf
  17. Mar 08, 2021
  18. Mar 05, 2021
  19. Mar 04, 2021
Loading