Skip to content
Snippets Groups Projects
  1. Apr 01, 2021
  2. Mar 31, 2021
  3. Mar 30, 2021
  4. Mar 29, 2021
  5. Mar 26, 2021
    • Dillon Dumesnil's avatar
      fix: AA-724: Updating the HiddenContentTransformer · 1614fb29
      Dillon Dumesnil authored
      We heard about a bug where learners granted extensions would still
      lose access to content if it was marked as "hidden after due date".
      This was caused by the HiddenContentTransformer using the due date
      from collection time (publish time) rather than the user date returned
      from the edx-when DateOverrideTransformer.
      
      A small subtletly of these PRs is that Transformers with the
      FilteringTransformerMixin are executed before those without it so
      part of the fix was to make the HiddenContentTransformer not use the
      FilteringTransformerMixin to ensure the DateOverrideTransformer had
      run first.
      
      Part 2/3 - Updating transform method + updating Read version
    • Dillon Dumesnil's avatar
      Merge pull request #27152 from edx/ddumesnil/hidden-content-fix-aa-724-part-1 · 85515283
      Dillon Dumesnil authored
      fix: AA-724: Updating the HiddenContentTransformer
    • Feanil Patel's avatar
      Merge pull request #27155 from edx/feanil/fix_request_user_logging · 5fe49137
      Feanil Patel authored
      fix: Don't make request change logging a waffle flag.
    • Feanil Patel's avatar
      fix: Don't make request change logging a waffle flag. · c1bdf018
      Feanil Patel authored
      Waffle flags are useful for gradual rollout but that's not possible this
      high in the middleware because a lot of the data needed (request.user)
      to partition incoming requests is not availabale this high in the
      middleware.
      
      Convert this to a WaffleSwitch which will be safer to operate.
      
      Also increase the number of frames in the stack to print per change.
      Printing just 1 did not provide enough info because DRF requests wrap
      WSGI requests and have a setter proxy.  It will be useful to figure out
      how they do this in case it's better that what we're doing in the safe
      sessions middleware.
      
      Ticket: https://openedx.atlassian.net/browse/ARCHBOM-1718
      c1bdf018
    • Dillon Dumesnil's avatar
      fix: AA-724: Updating the HiddenContentTransformer · d96f7569
      Dillon Dumesnil authored
      We heard about a bug where learners granted extensions would still
      lose access to content if it was marked as "hidden after due date".
      This was caused by the HiddenContentTransformer using the due date
      from collection time (publish time) rather than the user date returned
      from the edx-when DateOverrideTransformer.
      
      A small subtletly of these PRs is that Transformers with the
      FilteringTransformerMixin are executed before those without it so
      part of the fix was to make the HiddenContentTransformer not use the
      FilteringTransformerMixin to ensure the DateOverrideTransformer had
      run first.
      
      Part 1/3
Loading